From: Pieter Lexis <pieter.lexis@powerdns.com>
Date: Wed, 10 Dec 2025 09:57:57 +0000 (+0100)
Subject: fix(dnsdist): Ensure SetTraceAction compiles in non-PB builds
X-Git-Tag: rec-5.4.0-beta1~65^2~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=45bbe2c42c84f4f4e04baa635333a140f0ab3150;p=thirdparty%2Fpdns.git

fix(dnsdist): Ensure SetTraceAction compiles in non-PB builds
---

diff --git a/pdns/dnsdistdist/dnsdist-actions-factory.cc b/pdns/dnsdistdist/dnsdist-actions-factory.cc
index ba3245acb0..54fabf3959 100644
--- a/pdns/dnsdistdist/dnsdist-actions-factory.cc
+++ b/pdns/dnsdistdist/dnsdist-actions-factory.cc
@@ -1681,8 +1681,10 @@ private:
 class SetTraceAction : public DNSAction
 {
 public:
+#ifndef DISABLE_PROTOBUF
   SetTraceAction(SetTraceActionConfiguration& config) :
     d_value{config.value}, d_loggers(config.remote_loggers), d_useIncomingTraceID(config.use_incoming_traceid), d_incomingTraceIDOptionCode(config.trace_edns_option) {};
+#endif /* DISABLE_PROTOBUF */
 
   DNSAction::Action operator()([[maybe_unused]] DNSQuestion* dnsquestion, [[maybe_unused]] std::string* ruleresult) const override
   {
@@ -1725,9 +1727,14 @@ public:
 
   [[nodiscard]] std::string toString() const override
   {
+#ifndef DISABLE_PROTOBUF
     return string((d_value ? "en" : "dis")) + string("able OpenTelemetry Tracing");
+#else
+    return "";
+#endif
   }
 
+#ifndef DISABLE_PROTOBUF
 private:
   bool d_value;
 
@@ -1735,6 +1742,7 @@ private:
 
   std::optional<bool> d_useIncomingTraceID;
   std::optional<short unsigned int> d_incomingTraceIDOptionCode;
+#endif
 };
 
 class SNMPTrapAction : public DNSAction