From: Willem Toorop <willem@nlnetlabs.nl>
Date: Tue, 28 Jan 2025 13:57:14 +0000 (+0100)
Subject: Changelog entry for memory leaks
X-Git-Tag: 1.9.0-rc.1~25^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=45bdc6c07bc19d0826288d4117494850a53bd0a7;p=thirdparty%2Fldns.git

Changelog entry for memory leaks
---

diff --git a/Changelog b/Changelog
index 41e19e4e..e350bae7 100644
--- a/Changelog
+++ b/Changelog
@@ -11,6 +11,10 @@
 	  Follows the long string unquoted syntax from RFC8659, section 4.1.1.
 	* Fix #266: ldns-read-zone -u fails if a type is the only type in a
 	  window and the type modulo 256 is equal to zero.
+	* Fix memory leak when trying to read zones that have equal RRs.
+	  the ldns_dnssec_*_add_rr() functions now return LDNS_STATUS_EQUAL_RR
+	  when an already existing RR is tried to be added. This is a API
+	  change, hence this also bumps the version to 1.9.0
 
 1.8.4	2024-07-19
 	* Fix building documentation in build directory.
diff --git a/ldns/dnssec_zone.h b/ldns/dnssec_zone.h
index e1c6975e..335f57a3 100644
--- a/ldns/dnssec_zone.h
+++ b/ldns/dnssec_zone.h
@@ -315,7 +315,6 @@ int ldns_dnssec_name_cmp(const void *a, const void *b);
  *
  * \param[in] name The ldns_dnssec_name to add the RR to
  * \param[in] rr The RR to add
- * \return LDNS_STATUS_OK on success, error code otherwise
  * \return LDNS_STATUS_OK on success and LDNS_STATUS_EQUAL_ERR when and
  *         RR with equal ownername, class, type and rdata already exists,
  *         and an error code otherwise
@@ -420,7 +419,9 @@ void ldns_dnssec_zone_deep_free(ldns_dnssec_zone *zone);
  *
  * \param[in] zone the zone to add the RR to
  * \param[in] rr The RR to add
- * \return LDNS_STATUS_OK on success, an error code otherwise
+ * \return LDNS_STATUS_OK on success and LDNS_STATUS_EQUAL_ERR when and
+ *         RR with equal ownername, class, type and rdata already exists,
+ *         and an error code otherwise
  */
 ldns_status ldns_dnssec_zone_add_rr(ldns_dnssec_zone *zone,
 							 ldns_rr *rr);