From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Fri, 7 Jun 2024 13:42:39 +0000 (+0200)
Subject: dnsdist: Fix compiler warnings about reaching end of non-void functions
X-Git-Tag: rec-5.2.0-alpha1~172^2~16
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4607067693832214dc2a675be887d6c702650e23;p=thirdparty%2Fpdns.git

dnsdist: Fix compiler warnings about reaching end of non-void functions
---

diff --git a/pdns/dnsdistdist/dnsdist-rule-chains.cc b/pdns/dnsdistdist/dnsdist-rule-chains.cc
index 340e4006fb..57e7b74ea0 100644
--- a/pdns/dnsdistdist/dnsdist-rule-chains.cc
+++ b/pdns/dnsdistdist/dnsdist-rule-chains.cc
@@ -55,6 +55,8 @@ std::vector<RuleAction>& getRuleChain(RuleChains& chains, RuleChain chain)
   case RuleChain::CacheMissRules:
     return chains.d_cacheMissRuleActions;
   }
+
+  throw std::runtime_error("Trying to accept an invalid rule chain");
 }
 
 const std::vector<RuleAction>& getRuleChain(const RuleChains& chains, RuleChain chain)
@@ -65,6 +67,8 @@ const std::vector<RuleAction>& getRuleChain(const RuleChains& chains, RuleChain
   case RuleChain::CacheMissRules:
     return chains.d_cacheMissRuleActions;
   }
+
+  throw std::runtime_error("Trying to accept an invalid rule chain");
 }
 
 std::vector<ResponseRuleAction>& getRuleChain(RuleChains& chains, ResponseRuleChain chain)
@@ -91,6 +95,8 @@ std::vector<ResponseRuleAction>& getResponseRuleChain(RuleChains& chains, Respon
   case ResponseRuleChain::XFRResponseRules:
     return chains.d_XFRRespRuleActions;
   }
+
+  throw std::runtime_error("Trying to accept an invalid response rule chain");
 }
 
 const std::vector<ResponseRuleAction>& getResponseRuleChain(const RuleChains& chains, ResponseRuleChain chain)
@@ -107,6 +113,8 @@ const std::vector<ResponseRuleAction>& getResponseRuleChain(const RuleChains& ch
   case ResponseRuleChain::XFRResponseRules:
     return chains.d_XFRRespRuleActions;
   }
+
+  throw std::runtime_error("Trying to accept an invalid response rule chain");
 }
 
 void add(RuleChains& chains, RuleChain identifier, const std::shared_ptr<DNSRule>& selector, const std::shared_ptr<DNSAction>& action, std::string&& name, const boost::uuids::uuid& uuid, uint64_t creationOrder)