From: Stephan Bosch <stephan.bosch@open-xchange.com>
Date: Sun, 19 Nov 2023 00:08:53 +0000 (+0100)
Subject: auth: auth-request - Remove auth_request_new_dummy()
X-Git-Tag: 2.4.2~240
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=463e6f1aa89ad655f66cbe3da772b17732a1e5e3;p=thirdparty%2Fdovecot%2Fcore.git

auth: auth-request - Remove auth_request_new_dummy()

It is no longer different from auth_request_new()
---

diff --git a/src/auth/auth-master-connection.c b/src/auth/auth-master-connection.c
index cdf3cfd3d1..f0cef680c1 100644
--- a/src/auth/auth-master-connection.c
+++ b/src/auth/auth-master-connection.c
@@ -195,7 +195,7 @@ static int master_input_auth_request(struct auth_master_connection *conn,
 		return -1;
 	}
 
-	auth_request = auth_request_new_dummy(auth_event);
+	auth_request = auth_request_new(auth_event);
 	auth_request->id = id;
 	auth_request->master = conn;
 	auth_master_connection_ref(conn);
@@ -618,7 +618,7 @@ static int master_input_list(struct auth_master_connection *conn,
 		return 1;
 	}
 
-	auth_request = auth_request_new_dummy(auth_event);
+	auth_request = auth_request_new(auth_event);
 	auth_request->id = id;
 	auth_request->master = conn;
 	auth_master_connection_ref(conn);
diff --git a/src/auth/auth-request.c b/src/auth/auth-request.c
index 9a89494878..3bc0f555e9 100644
--- a/src/auth/auth-request.c
+++ b/src/auth/auth-request.c
@@ -162,19 +162,6 @@ struct auth_request *auth_request_new(struct event *parent_event)
 	return request;
 }
 
-struct auth_request *auth_request_new_dummy(struct event *parent_event)
-{
-	struct auth_request *request;
-	pool_t pool;
-
-	pool = pool_alloconly_create(MEMPOOL_GROWING"auth_request", 1024);
-	request = p_new(pool, struct auth_request, 1);
-	request->pool = pool;
-
-	auth_request_post_alloc_init(request, parent_event);
-	return request;
-}
-
 void auth_request_set_state(struct auth_request *request,
 			    enum auth_request_state state)
 {
diff --git a/src/auth/auth-worker-server.c b/src/auth/auth-worker-server.c
index 118a0c68de..1694102a6e 100644
--- a/src/auth/auth-worker-server.c
+++ b/src/auth/auth-worker-server.c
@@ -137,7 +137,7 @@ bool auth_worker_auth_request_new(struct auth_worker_command *cmd, unsigned int
 	struct auth_request *auth_request;
 	const char *key, *value;
 
-	auth_request = auth_request_new_dummy(cmd->event);
+	auth_request = auth_request_new(cmd->event);
 
 	cmd->server->refcount++;
 	auth_request->context = cmd;
diff --git a/src/auth/test-lua.c b/src/auth/test-lua.c
index f64f47eea5..ab177e9b46 100644
--- a/src/auth/test-lua.c
+++ b/src/auth/test-lua.c
@@ -18,7 +18,7 @@ static struct auth_settings test_lua_auth_set = {
 static struct auth_request *test_db_lua_auth_request_new(void)
 {
 	const char *error;
-	struct auth_request *req = auth_request_new_dummy(NULL);
+	struct auth_request *req = auth_request_new(NULL);
 	req->set = global_auth_settings;
 	struct event *event = event_create(req->event);
 	array_push_back(&req->authdb_event, &event);