From: lpsolit%gmail.com <>
Date: Wed, 30 Jan 2008 07:57:00 +0000 (+0000)
Subject: Bug 414726: Bugzilla::Update never updates bugzilla-update.xml if the file already... 
X-Git-Tag: bugzilla-3.0.4~53
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=464f169a7b564f58be19e8a5c41d2f8adf0fb51c;p=thirdparty%2Fbugzilla.git

Bug 414726: Bugzilla::Update never updates bugzilla-update.xml if the file already exists locally - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=LpSolit
---

diff --git a/Bugzilla/Update.pm b/Bugzilla/Update.pm
index f2b17a6b00..e9da91afb3 100644
--- a/Bugzilla/Update.pm
+++ b/Bugzilla/Update.pm
@@ -42,8 +42,16 @@ sub get_notifications {
         # but we failed because we cannot modify its timestamp?
         my $can_alter = 1;
         if (-e $local_file) {
-            # Try to alter its last modification time.
+            # Try to alter its last modification time. We first save the
+            # access and modification times of the file to restore them
+            # right after our test.
+            my $atime = (stat($local_file))[8];
+            my $mtime = (stat($local_file))[9];
             $can_alter = utime(undef, undef, $local_file);
+            # Restore the access and modification times to their
+            # original values, else LWP::UserAgent will never see the
+            # updated file on the server as newer than our local one.
+            utime($atime, $mtime, $local_file);
         }
         if ($can_alter) {
             my $error = _synchronize_data();
@@ -148,6 +156,8 @@ sub _synchronize_data {
     else {
         $ua->env_proxy;
     }
+    # Download the file from the server if its modification time is newer
+    # than the local one.
     $ua->mirror(REMOTE_FILE, $local_file);
 
     # $ua->mirror() forces the modification time of the local XML file