From: Yury Norov Date: Mon, 27 Apr 2026 21:41:21 +0000 (-0400) Subject: iio: magnetometer: yas530: switch to using FIELD_GET_SIGNED() X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=465af055db5b3804b4881e9cd07eeaea6dc3e460;p=thirdparty%2Fkernel%2Flinux.git iio: magnetometer: yas530: switch to using FIELD_GET_SIGNED() Switch from sign_extend32(FIELD_GET()) to the dedicated FIELD_GET_SIGNED() and don't calculate the fields length explicitly. Reviewed-by: Linus Walleij Acked-by: Jonathan Cameron Signed-off-by: Yury Norov --- diff --git a/drivers/iio/magnetometer/yamaha-yas530.c b/drivers/iio/magnetometer/yamaha-yas530.c index 140c422773f6a..c8a04f185dbbe 100644 --- a/drivers/iio/magnetometer/yamaha-yas530.c +++ b/drivers/iio/magnetometer/yamaha-yas530.c @@ -859,9 +859,9 @@ static int yas530_get_calibration_data(struct yas5xx *yas5xx) c->f[0] = FIELD_GET(GENMASK(22, 21), val); c->f[1] = FIELD_GET(GENMASK(14, 13), val); c->f[2] = FIELD_GET(GENMASK(6, 5), val); - c->r[0] = sign_extend32(FIELD_GET(GENMASK(28, 23), val), 5); - c->r[1] = sign_extend32(FIELD_GET(GENMASK(20, 15), val), 5); - c->r[2] = sign_extend32(FIELD_GET(GENMASK(12, 7), val), 5); + c->r[0] = FIELD_GET_SIGNED(GENMASK(28, 23), val); + c->r[1] = FIELD_GET_SIGNED(GENMASK(20, 15), val); + c->r[2] = FIELD_GET_SIGNED(GENMASK(12, 7), val); return 0; } @@ -914,9 +914,9 @@ static int yas532_get_calibration_data(struct yas5xx *yas5xx) c->f[0] = FIELD_GET(GENMASK(24, 23), val); c->f[1] = FIELD_GET(GENMASK(16, 15), val); c->f[2] = FIELD_GET(GENMASK(8, 7), val); - c->r[0] = sign_extend32(FIELD_GET(GENMASK(30, 25), val), 5); - c->r[1] = sign_extend32(FIELD_GET(GENMASK(22, 17), val), 5); - c->r[2] = sign_extend32(FIELD_GET(GENMASK(14, 7), val), 5); + c->r[0] = FIELD_GET_SIGNED(GENMASK(30, 25), val); + c->r[1] = FIELD_GET_SIGNED(GENMASK(22, 17), val); + c->r[2] = FIELD_GET_SIGNED(GENMASK(14, 7), val); return 0; }