From: Jo Sutton Date: Sun, 21 Apr 2024 23:10:00 +0000 (+1200) Subject: lib:crypto: Fix Coverity build X-Git-Tag: tdb-1.4.11~928 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=46955bc7664b8cf665c9bccf3b88d4afa26b9526;p=thirdparty%2Fsamba.git lib:crypto: Fix Coverity build The Coverity build is failing with the following errors: [1936/5164] Compiling lib/crypto/gkdi.c In file included from /usr/lib64/gcc/x86_64-suse-linux/7/include/stdint.h:9:0, from /usr/include/inttypes.h:27, from ../../lib/crypto/../replace/replace.h:64, from ../../source4/include/includes.h:23, from ../../lib/crypto/gkdi.c:21: ../../lib/crypto/gkdi.c: In function ‘gkdi_get_key_start_time’: ../../lib/crypto/gkdi.c:197:4: error: initializer element is not constant UINT64_MAX / ^ ../../lib/crypto/gkdi.c:197:4: note: (near initialization for ‘max_gkid.l0_idx’) ../../lib/crypto/gkdi.c:200:4: error: initializer element is not constant UINT64_MAX / ^ ../../lib/crypto/gkdi.c:200:4: note: (near initialization for ‘max_gkid.l1_idx’) ../../lib/crypto/gkdi.c:204:4: error: initializer element is not constant UINT64_MAX / gkdi_key_cycle_duration % ^ ../../lib/crypto/gkdi.c:204:4: note: (near initialization for ‘max_gkid.l2_idx’) Fix the build by removing the ‘static’ specifier on this constant. Signed-off-by: Jo Sutton Reviewed-by: Andrew Bartlett --- diff --git a/lib/crypto/gkdi.c b/lib/crypto/gkdi.c index af00ea4217e..ae269d64a3e 100644 --- a/lib/crypto/gkdi.c +++ b/lib/crypto/gkdi.c @@ -193,7 +193,7 @@ bool gkdi_get_key_start_time(const struct Gkid gkid, NTTIME *start_time_out) * Make sure that the GKID is not so large its start time can’t * be represented in NTTIME. */ - static const struct Gkid max_gkid = { + const struct Gkid max_gkid = { UINT64_MAX / (gkdi_l1_key_iteration * gkdi_l2_key_iteration * gkdi_key_cycle_duration),