From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 2 Aug 2022 12:41:31 +0000 (+0200)
Subject: qemuMonitorOpenUnix: Don't overwrite 'ret' needlessly
X-Git-Tag: v8.7.0-rc1~226
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=469f2ab31c28e04a3a1d06c2f9545307f1dd1a9c;p=thirdparty%2Flibvirt.git

qemuMonitorOpenUnix: Don't overwrite 'ret' needlessly

Directly check the return value of 'connect'. Unfortunately we can't
remove it as we have to undo auto-closing of the socket on success.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Jonathon Jongsma <jjongsma@redhat.com>
---

diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
index ad5e121359..0c0b07d4a5 100644
--- a/src/qemu/qemu_monitor.c
+++ b/src/qemu/qemu_monitor.c
@@ -245,8 +245,7 @@ qemuMonitorOpenUnix(const char *monitor)
         return -1;
     }
 
-    ret = connect(monfd, (struct sockaddr *) &addr, sizeof(addr));
-    if (ret < 0) {
+    if (connect(monfd, (struct sockaddr *) &addr, sizeof(addr)) < 0) {
         virReportSystemError(errno, "%s",
                              _("failed to connect to monitor socket"));
         return -1;