From: Alan T. DeKok <aland@freeradius.org>
Date: Wed, 9 May 2018 15:23:37 +0000 (-0400)
Subject: the transaction may be defunct
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=46b91eaa39dede2e4a232616a050fa6262de6c64;p=thirdparty%2Ffreeradius-server.git

the transaction may be defunct

If so, don't do REDEBUG
---

diff --git a/src/modules/rlm_sigtran/sccp.c b/src/modules/rlm_sigtran/sccp.c
index f1225337fca..2a66f7684bc 100644
--- a/src/modules/rlm_sigtran/sccp.c
+++ b/src/modules/rlm_sigtran/sccp.c
@@ -74,9 +74,16 @@ static void sigtran_tcap_timeout(void *data)
 	REQUEST *request;
 	sigtran_transaction_t *txn = talloc_get_type_abort(data, sigtran_transaction_t);
 
-	request = txn->ctx.request;
+	/*
+	 *	Only do RDEBUG if the transaction is still active.
+	 */
+	if (!txn->ctx.defunct) {
+		request = txn->ctx.request;
 
-	REDEBUG("OTID %u Invoke ID %u timeout", txn->ctx.otid, txn->ctx.invoke_id);
+		REDEBUG("OTID %u Invoke ID %u timeout", txn->ctx.otid, txn->ctx.invoke_id);
+	} else {
+		DEBUG("OTID %u Invoke ID %u timeout", txn->ctx.otid, txn->ctx.invoke_id);
+	}
 
 	/*
 	 *	Remove the outstanding transaction