From: Vladimír Čunát <vladimir.cunat@nic.cz>
Date: Thu, 15 Nov 2018 14:27:38 +0000 (+0100)
Subject: lib/resolve: eliminate double initialization
X-Git-Tag: v3.2.0~28^2~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=46cfc53d00fe6a56840c22a09b0271b530414f4c;p=thirdparty%2Fknot-resolver.git

lib/resolve: eliminate double initialization

It's just a few lines apart.  It's been generating lots of noise
in CI lint:clang-scan-build.
---

diff --git a/lib/resolve.c b/lib/resolve.c
index 4ef01b5d2..d4f0266f1 100644
--- a/lib/resolve.c
+++ b/lib/resolve.c
@@ -1031,7 +1031,6 @@ static int forward_trust_chain_check(struct kr_request *request, struct kr_query
 		return KR_STATE_PRODUCE;
 	}
 
-	const knot_dname_t *wanted_name = qry->sname;
 	const knot_dname_t *start_name = qry->sname;
 	if ((qry->flags.AWAIT_CUT) && !resume) {
 		qry->flags.AWAIT_CUT = false;
@@ -1059,12 +1058,9 @@ static int forward_trust_chain_check(struct kr_request *request, struct kr_query
 		return KR_STATE_DONE;
 	}
 
-	bool nods = false;
-	bool ds_req = false;
-	bool ns_req = false;
-	bool ns_exist = true;
-	bool minimized = false;
 	int name_offset = 1;
+	const knot_dname_t *wanted_name;
+	bool nods, ds_req, ns_req, minimized, ns_exist;
 	do {
 		wanted_name = start_name;
 		nods = false;