From: Greg Funni <gfunni234@gmail.com>
Date: Thu, 18 Dec 2025 16:10:49 +0000 (+0000)
Subject: refs: dereference the value of the required pointer
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=46d0ee2d6996779bf33acb83e36240443e27c79e;p=thirdparty%2Fgit.git

refs: dereference the value of the required pointer

Currently, this always prints yes because required is non-null.

This is the wrong behavior. The boolean must be
dereferenced.

Signed-off-by: Greg Funni <gfunni234@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/refs/debug.c b/refs/debug.c
index 36f8c58b6c..f3d1079a2c 100644
--- a/refs/debug.c
+++ b/refs/debug.c
@@ -131,7 +131,7 @@ static int debug_optimize_required(struct ref_store *ref_store,
 	struct debug_ref_store *drefs = (struct debug_ref_store *)ref_store;
 	int res = drefs->refs->be->optimize_required(drefs->refs, opts, required);
 	trace_printf_key(&trace_refs, "optimize_required: %s, res: %d\n",
-			 required ? "yes" : "no", res);
+			 *required ? "yes" : "no", res);
 	return res;
 }