From: Ralph Boehme Date: Thu, 27 Dec 2018 14:26:03 +0000 (+0100) Subject: Revert "smbd: explain that/why we use the raw tevent_context for update_write_time_ha... X-Git-Tag: talloc-2.1.15~152 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=46d3a1541a62bf0b2ae4d4ebc5f615b679dd7335;p=thirdparty%2Fsamba.git Revert "smbd: explain that/why we use the raw tevent_context for update_write_time_handler()" This reverts commit 7cfafaf190643eb28fc95d21a02a4e5e529e16d1. See the discussion in https://lists.samba.org/archive/samba-technical/2018-December/131731.html for the reasoning behind this revert. Signed-off-by: Ralph Boehme Reviewed-by: Volker Lendecke Reviewed-by: Stefan Metzmacher --- diff --git a/source3/smbd/fileio.c b/source3/smbd/fileio.c index 1fe806e058d..cde6a057ccd 100644 --- a/source3/smbd/fileio.c +++ b/source3/smbd/fileio.c @@ -232,17 +232,9 @@ void trigger_write_time_update(struct files_struct *fsp) DEBUG(5, ("Update write time %d usec later on %s\n", delay, fsp_str_dbg(fsp))); - /* - * trigger the update 2 seconds later - * - * Note that update_write_time_handler() - * => fsp_flush_write_time_update() - * won't do any SMB_VFS calls and don't - * need impersonation. So we use the - * raw event context for this. - */ + /* trigger the update 2 seconds later */ fsp->update_write_time_event = - tevent_add_timer(fsp->conn->sconn->raw_ev_ctx, NULL, + tevent_add_timer(fsp->conn->sconn->ev_ctx, NULL, timeval_current_ofs_usec(delay), update_write_time_handler, fsp); }