From: Dave Penkler Date: Mon, 17 Nov 2025 14:40:19 +0000 (+0100) Subject: staging: gpib: Update TODO file X-Git-Tag: v6.19-rc1~62^2~15 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=46e68568c18435795c7e6d74464c8096b752fc93;p=thirdparty%2Fkernel%2Fstable.git staging: gpib: Update TODO file The comments have now been fixed so remove the item about comments from the TODO file. Signed-off-by: Dave Penkler Link: https://patch.msgid.link/20251117144021.23569-3-dpenkler@gmail.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/gpib/TODO b/drivers/staging/gpib/TODO index ab41a7f9ca5bf..ac07dd90b4efd 100644 --- a/drivers/staging/gpib/TODO +++ b/drivers/staging/gpib/TODO @@ -4,20 +4,6 @@ TODO: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kmalloc(sizeof(*board->private_data)...) over kmalloc(sizeof(struct xxx_priv)...) ./gpio/gpib_bitbang.c:50: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parenthese This warning will be addressed later: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string -- tidy-up comments: - - there are some "//comments" and "// comments" scattered around - - sometimes they are misaligned - - sometimes "// comments" are interleaved with "/* comments */" - - multiline comments should start with initial almost-blank line: - /* - * Good - * multiline - * comment - */ - /* Bad - * multiline - * comment - */ - resolve XXX notes where possible - fix FIXME notes - clean-up commented-out code