From: Karsten Blees Date: Wed, 17 Dec 2025 14:08:47 +0000 (+0000) Subject: mingw: handle symlinks to directories in `mingw_unlink()` X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=47112d6f9671d2ed9e8034bf709442c279f53029;p=thirdparty%2Fgit.git mingw: handle symlinks to directories in `mingw_unlink()` The `_wunlink()` and `DeleteFileW()` functions refuse to delete symlinks to directories on Windows; The error code woutl be `ERROR_ACCESS_DENIED` in that case. Take that error code as an indicator that we need to try `_wrmdir()` as well. In the best case, it will remove a symlink. In the worst case, it will fail with the same error code again. Signed-off-by: Karsten Blees Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano --- diff --git a/compat/mingw.c b/compat/mingw.c index 0e8807196f..b1cc30d0f1 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -338,9 +338,16 @@ int mingw_unlink(const char *pathname, int handle_in_use_error) return 0; if (!is_file_in_use_error(GetLastError())) break; + /* + * _wunlink() / DeleteFileW() for directory symlinks fails with + * ERROR_ACCESS_DENIED (EACCES), so try _wrmdir() as well. This is the + * same error we get if a file is in use (already checked above). + */ + if (!_wrmdir(wpathname)) + return 0; + if (!handle_in_use_error) return -1; - } while (retry_ask_yes_no(&tries, "Unlink of file '%s' failed. " "Should I try again?", pathname)); return -1;