From: Jean Delvare Date: Mon, 19 May 2008 09:14:02 +0000 (+0200) Subject: i2c/max6875: Really prevent 24RF08 corruption X-Git-Tag: v2.6.25.6~37 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4715fd51f30c385fbc45ceb38dcd9a495487a2f8;p=thirdparty%2Fkernel%2Fstable.git i2c/max6875: Really prevent 24RF08 corruption commit 70455e790391dac85d9b483a9e286a40df1ecc7f in upstream i2c-core takes care of the possible corruption of 24RF08 chips for quite some times, so device drivers no longer need to do it. And they really should not, as applying the prevention twice voids it. I thought that I had fixed all drivers long ago but apparently I had missed that one. Signed-off-by: Jean Delvare Cc: Ben Gardner Signed-off-by: Greg Kroah-Hartman Signed-off-by: Chris Wright --- diff --git a/drivers/i2c/chips/max6875.c b/drivers/i2c/chips/max6875.c index fb7ea5637ecae..cf507b3f60f35 100644 --- a/drivers/i2c/chips/max6875.c +++ b/drivers/i2c/chips/max6875.c @@ -207,9 +207,6 @@ static int max6875_detect(struct i2c_adapter *adapter, int address, int kind) fake_client->flags = 0; strlcpy(fake_client->name, "max6875 subclient", I2C_NAME_SIZE); - /* Prevent 24RF08 corruption (in case of user error) */ - i2c_smbus_write_quick(real_client, 0); - if ((err = i2c_attach_client(real_client)) != 0) goto exit_kfree2;