From: Adrian Hunter Date: Tue, 13 Jan 2026 07:26:45 +0000 (+0200) Subject: i3c: master: Replace WARN_ON() with dev_err() in i3c_dev_free_ibi_locked() X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=471895799c2f46688792e175ced936ffeb6cdf01;p=thirdparty%2Fkernel%2Flinux.git i3c: master: Replace WARN_ON() with dev_err() in i3c_dev_free_ibi_locked() IBI disable failures are not indicative of a software bug, so using WARN_ON() is not appropriate. Replace these warnings with dev_err(). Signed-off-by: Adrian Hunter Reviewed-by: Frank Li Link: https://patch.msgid.link/20260113072702.16268-5-adrian.hunter@intel.com Signed-off-by: Alexandre Belloni --- diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index d684a6b799603..71583cc4d1970 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -3150,8 +3150,11 @@ void i3c_dev_free_ibi_locked(struct i3c_dev_desc *dev) if (!dev->ibi) return; - if (WARN_ON(dev->ibi->enabled)) - WARN_ON(i3c_dev_disable_ibi_locked(dev)); + if (dev->ibi->enabled) { + dev_err(&master->dev, "Freeing IBI that is still enabled\n"); + if (i3c_dev_disable_ibi_locked(dev)) + dev_err(&master->dev, "Failed to disable IBI before freeing\n"); + } master->ops->free_ibi(dev);