From: David Goulet <dgoulet@torproject.org>
Date: Wed, 9 Mar 2022 13:46:55 +0000 (-0500)
Subject: Merge branch 'maint-0.4.5' into maint-0.4.6
X-Git-Tag: tor-0.4.6.11~20^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=472c7127c7ad3f42879d48bd2eb8d461abdb6230;p=thirdparty%2Ftor.git

Merge branch 'maint-0.4.5' into maint-0.4.6
---

472c7127c7ad3f42879d48bd2eb8d461abdb6230
diff --cc src/feature/hs/hs_metrics.c
index 891029aded,25e2e62111..a82d2ae370
--- a/src/feature/hs/hs_metrics.c
+++ b/src/feature/hs/hs_metrics.c
@@@ -59,19 -59,26 +59,26 @@@ init_store(hs_service_t *service
    store = service->metrics.store;
  
    for (size_t i = 0; i < base_metrics_size; ++i) {
-     metrics_store_entry_t *entry =
-       metrics_store_add(store, base_metrics[i].type, base_metrics[i].name,
-                         base_metrics[i].help);
- 
-     /* Add labels to the entry. */
-     metrics_store_entry_add_label(entry,
-                         format_label("onion", service->onion_address));
+     /* Add entries with port as label. We need one metric line per port. */
      if (base_metrics[i].port_as_label && service->config.ports) {
        SMARTLIST_FOREACH_BEGIN(service->config.ports,
 -                              const rend_service_port_config_t *, p) {
 +                              const hs_port_config_t *, p) {
+         metrics_store_entry_t *entry =
+           metrics_store_add(store, base_metrics[i].type, base_metrics[i].name,
+                             base_metrics[i].help);
+ 
+         /* Add labels to the entry. */
+         metrics_store_entry_add_label(entry,
+                 format_label("onion", service->onion_address));
          metrics_store_entry_add_label(entry,
-                       format_label("port", port_to_str(p->virtual_port)));
+                 format_label("port", port_to_str(p->virtual_port)));
        } SMARTLIST_FOREACH_END(p);
+     } else {
+       metrics_store_entry_t *entry =
+         metrics_store_add(store, base_metrics[i].type, base_metrics[i].name,
+                           base_metrics[i].help);
+       metrics_store_entry_add_label(entry,
+               format_label("onion", service->onion_address));
      }
    }
  }