From: Jiri Denemark <jdenemar@redhat.com>
Date: Tue, 13 Aug 2019 11:16:20 +0000 (+0200)
Subject: qemu: Clarify error message in qemuMigrationSrcIsSafe
X-Git-Tag: v5.7.0-rc1~243
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4748f8df29e3ac4fe321ee60c1738cbfe378295e;p=thirdparty%2Flibvirt.git

qemu: Clarify error message in qemuMigrationSrcIsSafe

The original message was logically incorrect: cache != none or cache !=
directsync is always true. But even replacing "or" with "and" doesn't
make it more readable for humans.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Acked-By: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index c2570f7303..2bd1a464bf 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -1266,7 +1266,7 @@ qemuMigrationSrcIsSafe(virDomainDefPtr def,
 
         virReportError(VIR_ERR_MIGRATE_UNSAFE, "%s",
                        _("Migration may lead to data corruption if disks"
-                         " use cache != none or cache != directsync"));
+                         " use cache other than none or directsync"));
         return false;
     }