From: Jiri Popelka <jpopelka@redhat.com>
Date: Fri, 10 Jun 2011 13:25:57 +0000 (+0200)
Subject: iptables: Coverity: NEGATIVE_RETURNS
X-Git-Tag: v1.4.12~3^2~8
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=474c18d7982407246dd724c6fa3939f78466620a;p=thirdparty%2Fiptables.git

iptables: Coverity: NEGATIVE_RETURNS

libipq.c:232: var_tested_neg: Variable "h->fd" tests negative.
libipq.c:234: negative_returns: "h->fd" is passed to a parameter that
cannot be negative.

Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
---

diff --git a/libipq/libipq.c b/libipq/libipq.c
index e3304875..fb65971a 100644
--- a/libipq/libipq.c
+++ b/libipq/libipq.c
@@ -231,7 +231,6 @@ struct ipq_handle *ipq_create_handle(uint32_t flags, uint32_t protocol)
         
 	if (h->fd == -1) {
 		ipq_errno = IPQ_ERR_SOCKET;
-		close(h->fd);
 		free(h);
 		return NULL;
 	}