From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sat, 16 Oct 2021 09:39:25 +0000 (+0200)
Subject: refs API: don't expose "errno" in run_transaction_hook()
X-Git-Tag: v2.35.0-rc0~135^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4755d7dff7a27f431493926541fd6aab2e860aa4;p=thirdparty%2Fgit.git

refs API: don't expose "errno" in run_transaction_hook()

In run_transaction_hook() we've checked errno since 67541597670 (refs:
implement reference transaction hook, 2020-06-19), let's reset errno
afterwards to make sure nobody using refs.c directly or indirectly
relies on it.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/refs.c b/refs.c
index 43fe9e6d89..e90c59539b 100644
--- a/refs.c
+++ b/refs.c
@@ -2096,8 +2096,11 @@ static int run_transaction_hook(struct ref_transaction *transaction,
 			    update->refname);
 
 		if (write_in_full(proc.in, buf.buf, buf.len) < 0) {
-			if (errno != EPIPE)
+			if (errno != EPIPE) {
+				/* Don't leak errno outside this API */
+				errno = 0;
 				ret = -1;
+			}
 			break;
 		}
 	}