From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Mon, 27 May 2024 03:04:11 +0000 (-0400)
Subject: Reference count dl modules from 1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4758444314e52cdf1db2af36f4592db195e31ffb;p=thirdparty%2Ffreeradius-server.git

Reference count dl modules from 1
---

diff --git a/src/lib/server/dl_module.c b/src/lib/server/dl_module.c
index 7d1096c0eb7..6f7f5915614 100644
--- a/src/lib/server/dl_module.c
+++ b/src/lib/server/dl_module.c
@@ -243,10 +243,7 @@ static int _dl_module_free(dl_module_t *dl_module)
 	/*
 	 *	Decrement refcounts, freeing at zero
 	 */
-	if (dl_module->refs > 0) {
-		dl_module->refs--;
-		return -1;
-	}
+	if (--dl_module->refs > 0) return -1;
 
 	/*
 	 *	dl is empty if we tried to load it and failed.
@@ -364,6 +361,7 @@ dl_module_t *dl_module_alloc(dl_module_t const *parent, char const *name, dl_mod
 	dl_module->loader = dl_module_loader;
 	dl_module->parent = parent;
 	dl_module->type = type;
+	dl_module->refs = 1;
 	talloc_set_destructor(dl_module, _dl_module_free);	/* Do this late */
 
 	/*