From: Richard Weinberger Date: Wed, 9 Jan 2019 20:42:19 +0000 (+0100) Subject: sdk: Fix SDKIMAGE_LINGUAS handling X-Git-Tag: lucaceresoli/bug-15201-perf-libtraceevent-missing~15670 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=475a5d9ec21a329be973691734f9e8bcb332338c;p=thirdparty%2Fopenembedded%2Fopenembedded-core-contrib.git sdk: Fix SDKIMAGE_LINGUAS handling Currently SDKIMAGE_LINGUAS is broken for any inputs except "all". In the non-"all" case, each enabled language package is installed via pm.install("nativesdk-glibc-binary-localedata-%s.utf-8" % lang) This will throw a python exception since pm.install() expects a list of strings and not a string. Fix the problem by constructing a list. That way it is now also possible to call the package installer just once. Cc: "Burton, Ross" Fixes: 67615e01751b ("rootfs_rpm.bbclass: migrate image creation to dnf") Signed-off-by: Richard Weinberger Signed-off-by: Ross Burton --- diff --git a/meta/lib/oe/sdk.py b/meta/lib/oe/sdk.py index 153b07d76b4..878ee1647ff 100644 --- a/meta/lib/oe/sdk.py +++ b/meta/lib/oe/sdk.py @@ -95,8 +95,8 @@ class Sdk(object, metaclass=ABCMeta): if linguas == "all": pm.install_glob("nativesdk-glibc-binary-localedata-*.utf-8", sdk=True) else: - for lang in linguas.split(): - pm.install("nativesdk-glibc-binary-localedata-%s.utf-8" % lang) + pm.install(["nativesdk-glibc-binary-localedata-%s.utf-8" % \ + lang for lang in linguas.split()]) # Generate a locale archive of them target_arch = self.d.getVar('SDK_ARCH') rootfs = oe.path.join(self.sdk_host_sysroot, self.sdk_native_path)