From: Marek Schimara <Marek.Schimara@bull.net>
Date: Fri, 17 Jun 2016 08:15:31 +0000 (+0200)
Subject: src/rrd_hw.c: fix Coverity CIDs#13664,#13665 Resource leak
X-Git-Tag: v1.7.0~42^2~13
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=47614fea3231b3290bf1c52f222e53b5fa8a9241;p=thirdparty%2Frrdtool-1.x.git

src/rrd_hw.c: fix Coverity CIDs#13664,#13665 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html
---

diff --git a/src/rrd_hw.c b/src/rrd_hw.c
index ac726be8..4d74c1e9 100644
--- a/src/rrd_hw.c
+++ b/src/rrd_hw.c
@@ -262,6 +262,8 @@ int apply_smoother(
             rrd_set_error("apply smoother: SEASONAL rra doesn't have "
                           "valid dependency: %s",
                           rrd->rra_def[hw_dep_idx(rrd, rra_idx)].cf_nam);
+            free(rrd_values);
+            free(baseline);
             return -1;
         }
 
@@ -315,6 +317,7 @@ int apply_smoother(
         != (ssize_t) (sizeof(rrd_value_t) * row_length * row_count)) {
         rrd_set_error("apply_smoother: write failed to %lu", rra_start);
         free(rrd_values);
+        free(baseline);
         return -1;
     }