From: Christian Legnitto <clegnitto@mozilla.com>
Date: Wed, 3 Nov 2010 15:33:30 +0000 (+0100)
Subject: Bug 607909: Hours worked / work_time is marked as changing when commenting even when... 
X-Git-Tag: bugzilla-4.1.1~159
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=476aa64420a21efc15d50857c2ebbad3fb5de6db;p=thirdparty%2Fbugzilla.git

Bug 607909: Hours worked / work_time is marked as changing when commenting even when you don't enter a value
r/a=LpSolit
---

diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index e005b05c56..f5b0928008 100644
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -895,8 +895,8 @@ sub update {
         # timestamp.
         $comment->{bug_when} = $delta_ts;
         $comment = Bugzilla::Comment->insert_create_data($comment);
-        if ($comment->{work_time}) {
-            LogActivityEntry($self->id, "work_time", "", $comment->{work_time},
+        if ($comment->work_time) {
+            LogActivityEntry($self->id, "work_time", "", $comment->work_time,
                 Bugzilla->user->id, $delta_ts);
         }
     }
diff --git a/Bugzilla/Comment.pm b/Bugzilla/Comment.pm
index e8bdb4e899..7b9e257dfc 100644
--- a/Bugzilla/Comment.pm
+++ b/Bugzilla/Comment.pm
@@ -113,7 +113,11 @@ sub body        { return $_[0]->{'thetext'};   }
 sub bug_id      { return $_[0]->{'bug_id'};    }
 sub creation_ts { return $_[0]->{'bug_when'};  }
 sub is_private  { return $_[0]->{'isprivate'}; }
-sub work_time   { return $_[0]->{'work_time'}; }
+sub work_time   {
+    # Work time is returned as a string (see bug 607909)
+    return 0 if $_[0]->{'work_time'} + 0 == 0;
+    return $_[0]->{'work_time'};
+}
 sub type        { return $_[0]->{'type'};      }
 sub extra_data  { return $_[0]->{'extra_data'} }