From: Jouni Malinen <j@w1.fi>
Date: Fri, 27 Dec 2013 16:44:21 +0000 (+0200)
Subject: WNM: Fix AP processing without wnm_oper driver callback
X-Git-Tag: hostap_2_1~347
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=477689788c59f62a32c9d76e44838aa22bab0b05;p=thirdparty%2Fhostap.git

WNM: Fix AP processing without wnm_oper driver callback

hostapd_drv_wnm_oper() needs to indicate an error if the driver callback
function is not implemented. Without this, the buf_len argument could
have been left uninitialized which could result in crashing the process.

Signed-hostap: Jouni Malinen <j@w1.fi>
---

diff --git a/src/ap/ap_drv_ops.c b/src/ap/ap_drv_ops.c
index bd5d8b2f6..893e6d9ee 100644
--- a/src/ap/ap_drv_ops.c
+++ b/src/ap/ap_drv_ops.c
@@ -714,7 +714,7 @@ int hostapd_drv_wnm_oper(struct hostapd_data *hapd, enum wnm_oper oper,
 			 const u8 *peer, u8 *buf, u16 *buf_len)
 {
 	if (hapd->driver == NULL || hapd->driver->wnm_oper == NULL)
-		return 0;
+		return -1;
 	return hapd->driver->wnm_oper(hapd->drv_priv, oper, peer, buf,
 				      buf_len);
 }