From: Alan T. DeKok <aland@freeradius.org>
Date: Fri, 20 Oct 2017 22:46:41 +0000 (-0400)
Subject: use state_transition() in another place, too
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=478138c074073f4c79e5ceaa3ffa34854fb5cfe5;p=thirdparty%2Ffreeradius-server.git

use state_transition() in another place, too
---

diff --git a/src/modules/rlm_radius/rlm_radius_udp.c b/src/modules/rlm_radius/rlm_radius_udp.c
index adace2ad967..7096bb7ad9d 100644
--- a/src/modules/rlm_radius/rlm_radius_udp.c
+++ b/src/modules/rlm_radius/rlm_radius_udp.c
@@ -1796,32 +1796,9 @@ static int udp_request_free(rlm_radius_udp_request_t *u)
 {
 	struct timeval when, now;
 
-	fr_dlist_remove(&u->entry);
-
 	if (u->timer.ev) fr_event_timer_delete(u->thread->el, &u->timer.ev);
 
-	/*
-	 *	Delete any tracking entry associated with the packet.
-	 */
-	if (u->rr) {
-		rad_assert(u->c != NULL);
-		(void) rr_track_delete(u->c->id, u->rr);
-		u->rr = NULL;
-	}
-
-	switch (u->state) {
-	case PACKET_STATE_THREAD:
-		rad_assert(u->c == NULL);
-		(void) fr_heap_extract(u->thread->queued, u);
-		return 0;
-
-	case PACKET_STATE_SENT:
-		fr_dlist_remove(&u->entry);
-		break;
-
-	default:
-		break;
-	}
+	state_transition(u, PACKET_STATE_FINISHED);
 
 	/*
 	 *	We don't have a connection, so we can't update any of