From: Michał Kępień <michal@isc.org>
Date: Mon, 27 Oct 2025 09:56:38 +0000 (+0100)
Subject: Stop prettifying JSON statistics
X-Git-Tag: v9.21.15~35^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4797b2a1553a9fe32bd17fa20173fce24e280559;p=thirdparty%2Fbind9.git

Stop prettifying JSON statistics

Passing the JSON_C_TO_STRING_PRETTY flag to
json_object_to_json_string_ext() makes the latter produce prettified
JSON output.  This results in a huge amount of redundant whitespace
being inserted into each HTTP response (whitespace amounts to about 40%
of the entire JSON payload).

The bandwidth cost can be amortized by enabling HTTP compression on the
client side ("Accept-Encoding: deflate"), but that does not affect the
size of data at rest.

Use the JSON_C_TO_STRING_PLAIN flag instead of JSON_C_TO_STRING_PRETTY
to minimize the size of JSON responses sent via the statistics channel.
External tools should be used for prettifying JSON data.
---

diff --git a/bin/named/statschannel.c b/bin/named/statschannel.c
index d0a235e290a..eacb2d25eaa 100644
--- a/bin/named/statschannel.c
+++ b/bin/named/statschannel.c
@@ -3332,7 +3332,7 @@ generatejson(named_server_t *server, size_t *msglen, const char **msg,
 	}
 
 	*msg = json_object_to_json_string_ext(bindstats,
-					      JSON_C_TO_STRING_PRETTY);
+					      JSON_C_TO_STRING_PLAIN);
 	*msglen = strlen(*msg);
 
 	if (rootp != NULL) {