From: Jim Meyering <meyering@redhat.com>
Date: Mon, 3 Mar 2008 13:14:26 +0000 (+0000)
Subject: Plug virCapabilities*GuestDomain leak.
X-Git-Tag: LIBVIRT_0_4_1~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=47a4c0fa0bbda4fbb98ee0131dedf7b465723bb9;p=thirdparty%2Flibvirt.git

Plug virCapabilities*GuestDomain leak.

* src/capabilities.c (virCapabilitiesFreeGuestDomain): Free dom->type.
(virCapabilitiesAddGuestDomain): Remove duplicate strdup stmt.
---

diff --git a/ChangeLog b/ChangeLog
index 049f515d5b..2d54e8a83a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+Mon Mar  3 14:14:03 CET 2008 Jim Meyering <meyering@redhat.com>
+
+	Plug virCapabilities*GuestDomain leak.
+	* src/capabilities.c (virCapabilitiesFreeGuestDomain): Free dom->type.
+	(virCapabilitiesAddGuestDomain): Remove duplicate strdup stmt.
+
 Mon Mar  3 07:16:35 CET 2008 Daniel Veillard <veillard@redhat.com>
 
 	* include/libvirt/libvirt.h include/libvirt/libvirt.h.in:
diff --git a/src/capabilities.c b/src/capabilities.c
index 263935cf50..2544bd36ec 100644
--- a/src/capabilities.c
+++ b/src/capabilities.c
@@ -73,6 +73,7 @@ virCapabilitiesFreeGuestDomain(virCapsGuestDomainPtr dom)
     for (i = 0 ; i < dom->info.nmachines ; i++)
         free(dom->info.machines[i]);
     free(dom->info.machines);
+    free(dom->type);
 
     free(dom);
 }
@@ -328,9 +329,6 @@ virCapabilitiesAddGuestDomain(virCapsGuestPtr guest,
     if ((dom->type = strdup(hvtype)) == NULL)
         goto no_memory;
 
-    if ((dom->type = strdup(hvtype)) == NULL)
-        goto no_memory;
-
     if (emulator &&
         (dom->info.emulator = strdup(emulator)) == NULL)
         goto no_memory;