From: Miod Vallat <miod.vallat@powerdns.com>
Date: Thu, 12 Jun 2025 07:37:05 +0000 (+0200)
Subject: Drop domainid argument from DNSSECKeeper::startTransaction.
X-Git-Tag: dnsdist-2.0.0-beta1~27^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=47c61d9e00e5d0501605e131b71f4d1c292d4bde;p=thirdparty%2Fpdns.git

Drop domainid argument from DNSSECKeeper::startTransaction.

It is never used in a destructive way.
---

diff --git a/pdns/dnsseckeeper.hh b/pdns/dnsseckeeper.hh
index c454a1d714..7b5614f792 100644
--- a/pdns/dnsseckeeper.hh
+++ b/pdns/dnsseckeeper.hh
@@ -223,9 +223,9 @@ public:
   bool TSIGGrantsAccess(const ZoneName& zone, const DNSName& keyname);
   bool getTSIGForAccess(const ZoneName& zone, const ComboAddress& primary, DNSName* keyname);
 
-  void startTransaction(const ZoneName& zone, domainid_t zone_id)
+  void startTransaction(const ZoneName& zone)
   {
-    (*d_keymetadb->backends.begin())->startTransaction(zone, zone_id);
+    (*d_keymetadb->backends.begin())->startTransaction(zone);
   }
 
   void commitTransaction()
diff --git a/pdns/pdnsutil.cc b/pdns/pdnsutil.cc
index 6c51069658..ec90472462 100644
--- a/pdns/pdnsutil.cc
+++ b/pdns/pdnsutil.cc
@@ -3442,7 +3442,7 @@ static int secureZone(vector<string>& cmds, const std::string_view synopsis)
   unsigned int zoneErrors=0;
   for(unsigned int n = 1; n < cmds.size(); ++n) { // NOLINT(readability-identifier-length)
     ZoneName zone(cmds.at(n));
-    dk.startTransaction(zone, UnknownDomainID);
+    dk.startTransaction(zone);
     if(secureZone(dk, zone)) {
       mustRectify.push_back(std::move(zone));
     } else {