From: chandan Date: Thu, 26 Jan 2017 02:02:43 +0000 (-0600) Subject: xfs_db: Interpret inode's di_format field as unsigned X-Git-Tag: v4.10.0-rc1~12 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=47dd674372891cf2e5cc7d0bbba3e648653a235e;p=thirdparty%2Fxfsprogs-dev.git xfs_db: Interpret inode's di_format field as unsigned On a ppc64 big endian system, xfs_db would print the following, xfs_db> p core.magic = 0x494e core.mode = 0100600 core.version = 3 core.format = -253 This is due to fp_dinode_fmt() interpretting the di_format field as signed. This commit fixes the bug by passing BVUNSIGNED (instead of BVSIGNED) as the argument to getbitval(). With this commit applied, we now get, xfs_db> p core.magic = 0x494e core.mode = 0100600 core.version = 3 core.format = 3 (btree) Signed-off-by: Chandan Rajendra Reviewed-by: Darrick J. Wong Signed-off-by: Eric Sandeen --- diff --git a/db/inode.c b/db/inode.c index cac19fcfb..8b7a41e4b 100644 --- a/db/inode.c +++ b/db/inode.c @@ -238,7 +238,7 @@ fp_dinode_fmt( int i; for (i = 0, bitpos = bit; i < count; i++, bitpos += size) { - f = (xfs_dinode_fmt_t)getbitval(obj, bitpos, size, BVSIGNED); + f = (xfs_dinode_fmt_t)getbitval(obj, bitpos, size, BVUNSIGNED); if (array) dbprintf("%d:", i + base); if (f < 0 || f >= dinode_fmt_name_size)