From: Stefano Lattarini <stefano.lattarini@gmail.com>
Date: Wed, 25 May 2011 14:45:30 +0000 (+0200)
Subject: testsuite: require C++ compiler explicitly in tests needing it
X-Git-Tag: ng-0.5a~89^2~225
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=47fc204c850dd547d8d8dd28bdc07074d9179626;p=thirdparty%2Fautomake.git

testsuite: require C++ compiler explicitly in tests needing it

The list of the test scripts which needed a C++ compiler but
failed to require it explicitly has been found by running:
  $ tests=`grep -lE 'CXX|\.c(c|\+\+|xx|pp)' *.test | tr '\n' ' '`
  $ am_explicit_skips=yes CXX=false make check TESTS="$tests"
and looking for tests that reported FAIL instead of SKIP.
After the present change, all those previously failing tests
either pass or get correctly skipped.

* tests/subobj9.test: Require `c++', instead of explicitly
skipping on configure failure.  Add excerpts and/or details from
the original bug report that prompted this tests to be written.
* tests/silentcxx-gcc.test: Require g++.
* tests/silentcxx.test: Require c++.
* tests/suffix3.test: Likewise.
---

diff --git a/ChangeLog b/ChangeLog
index e7f480ff8..d26268d15 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,20 @@
+2011-05-25  Stefano Lattarini  <stefano.lattarini@gmail.com>
+
+	testsuite: require C++ compiler explicitly in tests needing it
+	The list of the test scripts which needed a C++ compiler but
+	failed to require it explicitly has been found by running:
+	  $ tests=`grep -lE 'CXX|\.c(c|\+\+|xx|pp)' *.test | tr '\n' ' '`
+	  $ am_explicit_skips=yes CXX=false make check TESTS="$tests"
+	and looking for tests that reported FAIL instead of SKIP.
+	After the present change, all those previously failing tests
+	either pass or get correctly skipped.
+	* tests/subobj9.test: Require `c++', instead of explicitly
+	skipping on configure failure.  Add excerpts and/or details from
+	the original bug report that prompted this tests to be written.
+	* tests/silentcxx-gcc.test: Require g++.
+	* tests/silentcxx.test: Require c++.
+	* tests/suffix3.test: Likewise.
+
 2011-05-25  Stefano Lattarini  <stefano.lattarini@gmail.com>
 
 	testsuite: don't require g++ where any C++ compiler is enough
diff --git a/tests/silentcxx-gcc.test b/tests/silentcxx-gcc.test
index 1f5768c2d..55f296d0a 100755
--- a/tests/silentcxx-gcc.test
+++ b/tests/silentcxx-gcc.test
@@ -18,6 +18,7 @@
 # This test requires the GNU C++ compiler; keep it in sync with sister
 # test `silentcxx.test', which should work with generic compilers.
 
+required=g++
 . ./defs || Exit 1
 
 mkdir sub
diff --git a/tests/silentcxx.test b/tests/silentcxx.test
index b4919c775..14825db24 100755
--- a/tests/silentcxx.test
+++ b/tests/silentcxx.test
@@ -19,6 +19,7 @@
 # sister test `silentcxx-gcc.test', which requires the GNU C++ compiler
 # and forces the use of gcc depmode.
 
+required=c++
 . ./defs || Exit 1
 
 mkdir sub
diff --git a/tests/subobj9.test b/tests/subobj9.test
index f0e900714..9bab174a1 100755
--- a/tests/subobj9.test
+++ b/tests/subobj9.test
@@ -16,8 +16,14 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 # Test for PR 312.
+#
+# == Report ==
+# When using non-recursive make to build a libtoolize-library from
+# sources in a subdirectory, 'make distcheck' fails because of incomplete
+# cleanup. "make clean" tries to remove `*.o' and `.../<file>.lo' but
+# forgets `.../<file>.o'.
 
-required=libtoolize
+required='c++ libtoolize'
 . ./defs || Exit 1
 
 cat > configure.in << END
@@ -60,8 +66,7 @@ $ACLOCAL
 $AUTOCONF
 $AUTOMAKE -a
 
-# Skip this test on configure errors (e.g., broken C++ compilers).
-./configure || skip_ "configure failure"
+./configure
 
 # Ensure './libtool --help' will use the right tool versions.
 export AUTOCONF AUTOMAKE
diff --git a/tests/suffix3.test b/tests/suffix3.test
index e0c01f618..70385feae 100755
--- a/tests/suffix3.test
+++ b/tests/suffix3.test
@@ -17,6 +17,7 @@
 
 # Test to make sure that suffix rules chain.
 
+required=c++
 . ./defs || Exit 1
 
 cat >> configure.in << 'END'