From: Simon McVittie <smcv@collabora.com>
Date: Thu, 25 Oct 2018 15:47:18 +0000 (+0100)
Subject: sysdeps: Return an error for _dbus_command_for_pid on Windows
X-Git-Tag: dbus-1.13.8~38^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=47fc3ed2a9da3bbeb8b4004c8482ca56f69dcf55;p=thirdparty%2Fdbus.git

sysdeps: Return an error for _dbus_command_for_pid on Windows

If a function returns boolean for success/error, and returns a
DBusError, then it should set the DBusError if and only if it
returns FALSE.

Signed-off-by: Simon McVittie <smcv@collabora.com>
---

diff --git a/dbus/dbus-sysdeps-util-win.c b/dbus/dbus-sysdeps-util-win.c
index 5aad2a86a..fc3569080 100644
--- a/dbus/dbus-sysdeps-util-win.c
+++ b/dbus/dbus-sysdeps-util-win.c
@@ -1399,7 +1399,8 @@ _dbus_command_for_pid (unsigned long  pid,
                        int            max_len,
                        DBusError     *error)
 {
-  // FIXME
+  dbus_set_error (error, DBUS_ERROR_NOT_SUPPORTED,
+                  "_dbus_command_for_pid() not implemented on Windows");
   return FALSE;
 }