From: Ondrej Zajicek (work) <santiago@crfreenet.org>
Date: Mon, 30 Sep 2019 17:10:14 +0000 (+0200)
Subject: BFD: Fix reconfiguration of neighbors
X-Git-Tag: v2.0.7~15
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4821251ebb13c05e8752f6f54b8e5ad6d87fecaa;p=thirdparty%2Fbird.git

BFD: Fix reconfiguration of neighbors

The bfd_reconfigure_neighbors() returned after first reconfigured
neighbor instead of continuing with the next one.

Thanks to Winston Chen for the bugreport and a patch.
---

diff --git a/proto/bfd/bfd.c b/proto/bfd/bfd.c
index f774e67b0..a3e6d01cc 100644
--- a/proto/bfd/bfd.c
+++ b/proto/bfd/bfd.c
@@ -837,10 +837,11 @@ bfd_reconfigure_neighbors(struct bfd_proto *p, struct bfd_config *new)
 
 	nn->req = on->req;
 	nn->active = 1;
-	return;
+	goto next;
       }
 
     bfd_stop_neighbor(p, on);
+  next:;
   }
 
   WALK_LIST(nn, new->neigh_list)