From: Michal Privoznik <mprivozn@redhat.com>
Date: Thu, 29 Jul 2021 13:41:51 +0000 (+0200)
Subject: vmx: Drop needless check in virVMXParseDisk()
X-Git-Tag: v7.7.0-rc1~184
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=48344c640f1d7ffa097b1aaa96e42f173b6131e1;p=thirdparty%2Flibvirt.git

vmx: Drop needless check in virVMXParseDisk()

After previous patch it can no longer happen that @def will be
NULL and *def won't be.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c
index 4dc29b57a6..a9d0c6fece 100644
--- a/src/vmx/vmx.c
+++ b/src/vmx/vmx.c
@@ -2213,11 +2213,6 @@ virVMXParseDisk(virVMXContext *ctx, virDomainXMLOption *xmlopt, virConf *conf,
     char mode_name[32] = "";
     char *mode = NULL;
 
-    if (def == NULL || *def != NULL) {
-        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Invalid argument"));
-        return -1;
-    }
-
     if (!(*def = virDomainDiskDefNew(xmlopt)))
         return -1;