From: Amos Jeffries <squid3@treenet.co.nz>
Date: Thu, 5 Mar 2015 10:09:39 +0000 (-0800)
Subject: Remove useless checks in rev.13951
X-Git-Tag: merge-candidate-3-v1~227
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4846303fa24408bc38fc6a35ec79398ebf7eda54;p=thirdparty%2Fsquid.git

Remove useless checks in rev.13951

Being overly paranoid it seems.

 Detected by Coverity Scan. Issue 1273436
---

diff --git a/src/tunnel.cc b/src/tunnel.cc
index 485de198ff..9dfcb7dd8d 100644
--- a/src/tunnel.cc
+++ b/src/tunnel.cc
@@ -696,9 +696,8 @@ tunnelDelayedClientRead(void *data)
 {
     if (!data)
         return;
+
     TunnelStateData *tunnel = static_cast<TunnelStateData*>(data);
-    if (!tunnel)
-        return;
     tunnel->client.readPending = NULL;
     static uint64_t counter=0;
     debugs(26, 7, "Client read(2) delayed " << ++counter << " times");
@@ -710,9 +709,8 @@ tunnelDelayedServerRead(void *data)
 {
     if (!data)
         return;
+
     TunnelStateData *tunnel = static_cast<TunnelStateData*>(data);
-    if (!tunnel)
-        return;
     tunnel->server.readPending = NULL;
     static uint64_t counter=0;
     debugs(26, 7, "Server read(2) delayed " << ++counter << " times");