From: Stefan Metzmacher <metze@samba.org>
Date: Fri, 7 Feb 2025 14:24:50 +0000 (+0100)
Subject: winbindd: wbint_bh_raw_call_child_done() doesn't have state->domain
X-Git-Tag: tevent-0.17.0~847
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=485204b4fadb3f70d0f3835a572c1e53fa6a8268;p=thirdparty%2Fsamba.git

winbindd: wbint_bh_raw_call_child_done() doesn't have state->domain

Only child or domain binding handles are possible!

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/winbindd/winbindd_dual_ndr.c b/source3/winbindd/winbindd_dual_ndr.c
index 0b44dbedb08..219596b9fc0 100644
--- a/source3/winbindd/winbindd_dual_ndr.c
+++ b/source3/winbindd/winbindd_dual_ndr.c
@@ -176,11 +176,6 @@ static void wbint_bh_raw_call_child_done(struct tevent_req *subreq)
 		return;
 	}
 
-	if (state->domain != NULL) {
-		wcache_store_ndr(state->domain, state->opnum,
-				 &state->in_data, &state->out_data);
-	}
-
 	tevent_req_done(req);
 }
 
@@ -523,6 +518,9 @@ struct dcerpc_binding_handle *wbint_binding_handle(TALLOC_CTX *mem_ctx,
 	struct dcerpc_binding *b = NULL;
 	NTSTATUS status;
 
+	SMB_ASSERT((domain != NULL && child == NULL) ||
+		  (domain == NULL && child != NULL));
+
 	h = dcerpc_binding_handle_create(mem_ctx,
 					 &wbint_bh_ops,
 					 NULL,