From: Koosha Khajeh Moogahi <koosha.khajeh@gmail.com>
Date: Tue, 24 Apr 2012 18:27:35 +0000 (+0200)
Subject: Bug 645427: Bugzilla->usage_mode( USAGE_MODE_BROWSER ) doesn't change Bugzilla->usage... 
X-Git-Tag: bugzilla-4.3.2~94
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4862600fbf51d9f468f69e198f7e50648250235a;p=thirdparty%2Fbugzilla.git

Bug 645427: Bugzilla->usage_mode( USAGE_MODE_BROWSER ) doesn't change Bugzilla->usage_mode
r/a=LpSolit
---

diff --git a/Bugzilla.pm b/Bugzilla.pm
index 8928ff8b08..621222e8ae 100644
--- a/Bugzilla.pm
+++ b/Bugzilla.pm
@@ -485,8 +485,14 @@ sub usage_mode {
         }
         $class->request_cache->{usage_mode} = $newval;
     }
-    return $class->request_cache->{usage_mode}
-        || (i_am_cgi()? USAGE_MODE_BROWSER : USAGE_MODE_CMDLINE);
+
+    # XXX - Once we require Perl 5.10.1, this test can be replaced by //.
+    if (exists $class->request_cache->{usage_mode}) {
+        return $class->request_cache->{usage_mode};
+    }
+    else {
+        return (i_am_cgi()? USAGE_MODE_BROWSER : USAGE_MODE_CMDLINE);
+    }
 }
 
 sub installation_mode {