From: Miod Vallat <miod.vallat@powerdns.com>
Date: Wed, 23 Apr 2025 12:41:15 +0000 (+0200)
Subject: Apply suggestions from code review
X-Git-Tag: dnsdist-2.0.0-alpha2~65^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=48965303611dd5407175d3e97e1fd713b52015ea;p=thirdparty%2Fpdns.git

Apply suggestions from code review

Tweak log messages a little.

Co-authored-by: Peter van Dijk <peter.van.dijk@powerdns.com>
---

diff --git a/pdns/dnsbackend.hh b/pdns/dnsbackend.hh
index 2cf72f6862..1f4795f5b6 100644
--- a/pdns/dnsbackend.hh
+++ b/pdns/dnsbackend.hh
@@ -249,7 +249,7 @@ public:
 
   virtual bool getBeforeAndAfterNamesAbsolute(uint32_t /* id */, const DNSName& qname, DNSName& /* unhashed */, DNSName& /* before */, DNSName& /* after */)
   {
-    throw PDNSException("DNSSEC operation invoked on non-DNSSEC capable backend, qname: '" + qname.toString() + "'");
+    throw PDNSException("DNSSEC operation invoked on non-DNSSEC capable backend, qname: '" + qname.toLogString() + "'");
   }
 
   virtual bool getBeforeAndAfterNames(uint32_t /* id */, const ZoneName& zonename, const DNSName& qname, DNSName& before, DNSName& after);
diff --git a/pdns/packethandler.cc b/pdns/packethandler.cc
index 9a7d64131b..035a091780 100644
--- a/pdns/packethandler.cc
+++ b/pdns/packethandler.cc
@@ -986,7 +986,7 @@ void PacketHandler::addNSEC(DNSPacket& /* p */, std::unique_ptr<DNSPacket>& r, c
     // zone in a second, DNSSEC-capable backend, which caused d_dnssec to
     // be set to true. While it would be nice to support such a zone
     // configuration, we don't. Log a warning and skip DNSSEC processing.
-    g_log << Logger::Notice << "Backend for zone '" << d_sd.qname << "' does not support DNSSEC operation, not adding NSEC hashes" << endl;
+    g_log << Logger::Notice << "Backend for zone '" << d_sd.qname << "' does not support DNSSEC operation, not adding NSEC records" << endl;
     return;
   }