From: Daniel P. Berrange <berrange@redhat.com>
Date: Fri, 20 Jul 2012 13:52:44 +0000 (+0100)
Subject: Ensure failure to talk to Xen hypervisor is fatal when privileged
X-Git-Tag: CVE-2012-3445~93
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=489900e3de9de74ce4197807935ffc3ef8a68bca;p=thirdparty%2Flibvirt.git

Ensure failure to talk to Xen hypervisor is fatal when privileged

As per the comment, the Xen hypervisor driver is considered to
be mandatory when running privileged. When it fails to open,
we should thus return an error, not ignore it.
---

diff --git a/src/xen/xen_driver.c b/src/xen/xen_driver.c
index 9ff3d292d7..43b262061e 100644
--- a/src/xen/xen_driver.c
+++ b/src/xen/xen_driver.c
@@ -340,6 +340,8 @@ xenUnifiedOpen (virConnectPtr conn, virConnectAuthPtr auth, unsigned int flags)
         if (xenHypervisorOpen(conn, auth, flags) == VIR_DRV_OPEN_SUCCESS) {
             VIR_DEBUG("Activated hypervisor sub-driver");
             priv->opened[XEN_UNIFIED_HYPERVISOR_OFFSET] = 1;
+        } else {
+            goto fail;
         }
     }