From: David Sommerseth Date: Fri, 27 Sep 2019 22:45:36 +0000 (+0200) Subject: Improve the comments related to auth-token-hmac patches X-Git-Tag: v2.5_beta1~271 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=48a4c81b91bb5978cf21213fe5a85b80962025ee;p=thirdparty%2Fopenvpn.git Improve the comments related to auth-token-hmac patches A couple of places the documentation was not clear enough or not even correct. Just improve this to avoid confusion later on. Signed-off-by: David Sommerseth Acked-by: Gert Doering Message-Id: <20190927224536.27480-4-davids@openvpn.net> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg18874.html Signed-off-by: Gert Doering --- diff --git a/src/openvpn/auth_token.h b/src/openvpn/auth_token.h index c10afde91..4b014d44a 100644 --- a/src/openvpn/auth_token.h +++ b/src/openvpn/auth_token.h @@ -61,8 +61,6 @@ generate_auth_token(const struct user_pass *up, struct tls_multi *multi); * Verifies the auth token to be in the format that generate_auth_token * create and checks if the token is valid. * - * Also calls generate_auth_token to update the auth-token to extend - * its validity */ unsigned verify_auth_token(struct user_pass *up, struct tls_multi *multi, diff --git a/src/openvpn/ssl_common.h b/src/openvpn/ssl_common.h index 5e21009e6..8dd08862d 100644 --- a/src/openvpn/ssl_common.h +++ b/src/openvpn/ssl_common.h @@ -559,7 +559,7 @@ struct tls_multi * Auth-token is only valid for an empty username * and not the username actually supplied from the client * - * OpenVPN 3 clients sometimes the empty username with a + * OpenVPN 3 clients sometimes wipes or replaces the username with a * username hint from their config. */ int auth_token_state_flags;