From: Jakub Kicinski Date: Fri, 3 Apr 2026 22:51:07 +0000 (-0700) Subject: Merge branch 'net-macb-remove-dedicated-irq-handler-for-wol' X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=48a5e77b49ff304f5ad76d07c864e4b2257493c3;p=thirdparty%2Fkernel%2Flinux.git Merge branch 'net-macb-remove-dedicated-irq-handler-for-wol' Kevin Hao says: ==================== net: macb: Remove dedicated IRQ handler for WoL During debugging of a suspend/resume issue, I observed that the macb driver employs a dedicated IRQ handler for Wake-on-LAN (WoL) support. To my knowledge, no other Ethernet driver adopts this approach. This implementation unnecessarily complicates the suspend/resume process without providing any clear benefit. Instead, we can easily modify the existing IRQ handler to manage WoL events, avoiding any overhead in the TX/RX hot path. The net throughput shows no significant difference following these changes. The following data(net throughput and execution time of macb_interrupt) were collected from my AMD Zynqmp board using the commands: taskset -c 1,2,3 iperf3 -c 192.168.3.4 -t 60 -Z -P 3 -R cat /sys/kernel/debug/tracing/trace_stat/function0 Before: ------- [SUM] 0.00-60.00 sec 5.99 GBytes 858 Mbits/sec 0 sender [SUM] 0.00-60.00 sec 5.99 GBytes 857 Mbits/sec receiver Function Hit Time Avg s^2 -------- --- ---- --- --- macb_interrupt 217996 678425.2 us 3.112 us 1.446 us After: ------ [SUM] 0.00-60.00 sec 6.00 GBytes 858 Mbits/sec 0 sender [SUM] 0.00-60.00 sec 5.99 GBytes 857 Mbits/sec receiver Function Hit Time Avg s^2 -------- --- ---- --- --- macb_interrupt 218212 668107.3 us 3.061 us 1.413 us ==================== Link: https://patch.msgid.link/20260402-macb-irq-v2-0-942d98ab1154@gmail.com Signed-off-by: Jakub Kicinski --- 48a5e77b49ff304f5ad76d07c864e4b2257493c3