From: Amos Jeffries <squid3@treenet.co.nz>
Date: Sat, 13 Oct 2012 06:02:36 +0000 (-0600)
Subject: Fix using assignment as a condition without parentheses
X-Git-Tag: SQUID_3_3_0_1~14
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=48b4ed31ff36930dd4589f25536ab4207cc06ad6;p=thirdparty%2Fsquid.git

Fix using assignment as a condition without parentheses
---

diff --git a/src/ipcache.cc b/src/ipcache.cc
index 08768200ee..dba1ce0734 100644
--- a/src/ipcache.cc
+++ b/src/ipcache.cc
@@ -434,7 +434,7 @@ ipcacheParse(ipcache_entry *i, const char *inbuf)
         memset(i->addrs.bad_mask, 0, sizeof(unsigned char) * ipcount);
 
         for (j = 0, k = 0; k < ipcount; ++k) {
-            if ( i->addrs.in_addrs[j] = A[k] )
+            if ((i->addrs.in_addrs[j] = A[k]))
                 ++j;
             else
                 debugs(14, DBG_IMPORTANT, "ipcacheParse: Invalid IP address '" << A[k] << "' in response to '" << name << "'");