From: Timo Sirainen <tss@iki.fi>
Date: Tue, 25 Nov 2003 01:26:26 +0000 (+0200)
Subject: IMAP AUTHENTICATE and POP3 AUTH commands could have left the process stuck
X-Git-Tag: 1.1.alpha1~4212
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=48fc20cea83c68d4484af70bf88b85ed133f444d;p=thirdparty%2Fdovecot%2Fcore.git

IMAP AUTHENTICATE and POP3 AUTH commands could have left the process stuck
doing nothing forever.

--HG--
branch : HEAD
---

diff --git a/src/imap-login/client-authenticate.c b/src/imap-login/client-authenticate.c
index f285ac9acf..f01f7ef48c 100644
--- a/src/imap-login/client-authenticate.c
+++ b/src/imap-login/client-authenticate.c
@@ -241,8 +241,10 @@ static void client_auth_input(void *context)
 	char *line;
 	size_t linelen, bufsize;
 
-	if (!client_read(client))
+	if (!client_read(client)) {
+		client_unref(client);
 		return;
+	}
 
 	if (client->skip_line) {
 		if (i_stream_next_line(client->input) == NULL)
diff --git a/src/pop3-login/client-authenticate.c b/src/pop3-login/client-authenticate.c
index ca7f849a2e..6f5203ea69 100644
--- a/src/pop3-login/client-authenticate.c
+++ b/src/pop3-login/client-authenticate.c
@@ -237,8 +237,10 @@ static void client_auth_input(void *context)
 	char *line;
 	size_t linelen, bufsize;
 
-	if (!client_read(client))
+	if (!client_read(client)) {
+		client_unref(client);
 		return;
+	}
 
 	/* @UNSAFE */
 	line = i_stream_next_line(client->input);