From: Stefano Lattarini Date: Thu, 16 May 2013 10:13:32 +0000 (+0200) Subject: maint: tests no longer need to have executable bit set X-Git-Tag: v1.13.2b~56 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=48fc2d83362b4ad62e9e88dfec1cba6b934b8963;p=thirdparty%2Fautomake.git maint: tests no longer need to have executable bit set It has been a while since they are runnable only through "make check" or "./runtest", and not directly. * HACKING: Adjust. * t/README: Likewise, and updated the surrounding text to get rid of obsolete statements and advices. Signed-off-by: Stefano Lattarini --- diff --git a/HACKING b/HACKING index cebcb7246..3ce2e66df 100644 --- a/HACKING +++ b/HACKING @@ -264,8 +264,6 @@ * Use "make check" and "make maintainer-check" liberally. -* Make sure each test file is executable. - * Export the 'keep_testdirs' environment variable to "yes" to keep test directories for successful tests also. diff --git a/t/README b/t/README index 02cb3a5a9..60eb7c76d 100644 --- a/t/README +++ b/t/README @@ -254,9 +254,9 @@ Writing test cases by a C++ compiler, for similar reasons (i.e., the isatty(3) function from that same unistd.h header would be required otherwise). -* Before commit: make sure the test is executable, add the tests to - TESTS in Makefile.am, add it to XFAIL_TESTS in addition if needed, - write a ChangeLog entry, send the diff to . +* Add any new test to handwritten_TESTS in 't/list-of-tests.mk', and + to XFAIL_TESTS in addition if needed (that is, if the test is expected + to fail). * In test scripts, prefer using POSIX constructs over their old Bourne-only equivalents: