From: Daniel P. Berrange <berrange@redhat.com>
Date: Mon, 10 Sep 2012 15:47:15 +0000 (+0100)
Subject: Call virResetLastError in all virConnectOpen* functions
X-Git-Tag: CVE-2012-4423~45
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=48fea23ba5b1a8383343916ef2f10cfa1c40dabe;p=thirdparty%2Flibvirt.git

Call virResetLastError in all virConnectOpen* functions

All public API functions must call virResetLastError to clear
out any previous error. The virConnectOpen* functions forgot
to do this.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---

diff --git a/src/libvirt.c b/src/libvirt.c
index 686af8a744..563985062f 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@ -1329,6 +1329,7 @@ virConnectOpen (const char *name)
             goto error;
 
     VIR_DEBUG("name=%s", name);
+    virResetLastError();
     ret = do_open (name, NULL, 0);
     if (!ret)
         goto error;
@@ -1363,6 +1364,7 @@ virConnectOpenReadOnly(const char *name)
             goto error;
 
     VIR_DEBUG("name=%s", name);
+    virResetLastError();
     ret = do_open (name, NULL, VIR_CONNECT_RO);
     if (!ret)
         goto error;
@@ -1401,6 +1403,7 @@ virConnectOpenAuth(const char *name,
             goto error;
 
     VIR_DEBUG("name=%s, auth=%p, flags=%x", NULLSTR(name), auth, flags);
+    virResetLastError();
     ret = do_open (name, auth, flags);
     if (!ret)
         goto error;