From: Arnd Bergmann Date: Tue, 4 Mar 2025 14:35:58 +0000 (+0100) Subject: EDAC/device: Fix dev_set_name() format string X-Git-Tag: v6.15-rc1~198^2~1 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=49472722d920ad39208a21eed1e8dc9038b4c2da;p=thirdparty%2Flinux.git EDAC/device: Fix dev_set_name() format string Passing a variable string as the format to dev_set_name() causes a W=1 warning: drivers/edac/edac_device.c:736:9: error: format not a string literal and no format arguments [-Werror=format-security] 736 | ret = dev_set_name(&ctx->dev, name); | ^~~ Use a literal "%s" instead so the name can be the argument. Fixes: db99ea5f2c03 ("EDAC: Add support for EDAC device features control") Signed-off-by: Arnd Bergmann Signed-off-by: Borislav Petkov (AMD) Link: https://lore.kernel.org/r/20250304143603.995820-1-arnd@kernel.org --- diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c index 16611515ab348..0734909b08a4f 100644 --- a/drivers/edac/edac_device.c +++ b/drivers/edac/edac_device.c @@ -733,7 +733,7 @@ int edac_dev_register(struct device *parent, char *name, ctx->private = private; dev_set_drvdata(&ctx->dev, ctx); - ret = dev_set_name(&ctx->dev, name); + ret = dev_set_name(&ctx->dev, "%s", name); if (ret) goto data_mem_free;