From: Paul Eggleton Date: Thu, 11 Aug 2016 03:37:00 +0000 (+1200) Subject: siggen: properly close files rather than opening them inline X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=49502685df3e616023df352823156381b1f79cd3;p=thirdparty%2Fopenembedded%2Fopenembedded-core-contrib.git siggen: properly close files rather than opening them inline If you don't do this, with Python 3 you get a warning on exit under some circumstances. Signed-off-by: Paul Eggleton Signed-off-by: Richard Purdie --- diff --git a/lib/bb/siggen.py b/lib/bb/siggen.py index 5d8a253a1fe..9b2f658a460 100644 --- a/lib/bb/siggen.py +++ b/lib/bb/siggen.py @@ -363,10 +363,12 @@ def clean_basepaths_list(a): def compare_sigfiles(a, b, recursecb = None): output = [] - p1 = pickle.Unpickler(open(a, "rb")) - a_data = p1.load() - p2 = pickle.Unpickler(open(b, "rb")) - b_data = p2.load() + with open(a, 'rb') as f: + p1 = pickle.Unpickler(ff) + a_data = p1.load() + with open(b, 'rb') as f: + p2 = pickle.Unpickler(f) + b_data = p2.load() def dict_diff(a, b, whitelist=set()): sa = set(a.keys()) @@ -563,8 +565,9 @@ def calc_taskhash(sigdata): def dump_sigfile(a): output = [] - p1 = pickle.Unpickler(open(a, "rb")) - a_data = p1.load() + with open(a, 'rb') as f: + p1 = pickle.Unpickler(f) + a_data = p1.load() output.append("basewhitelist: %s" % (a_data['basewhitelist']))