From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 15 Nov 2015 21:42:27 +0000 (+0100)
Subject: ACPI-EC: Drop unnecessary check made before calling acpi_ec_delete_query()
X-Git-Tag: v4.4-rc2~16^2^3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4981c2b7abfe92a7ad3c9888b8a1ada552d49406;p=thirdparty%2Fkernel%2Flinux.git

ACPI-EC: Drop unnecessary check made before calling acpi_ec_delete_query()

The acpi_ec_delete_query() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
[ rjw: Subject ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index f61a7c8345406..b420fb46669dd 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -1103,7 +1103,7 @@ static int acpi_ec_query(struct acpi_ec *ec, u8 *data)
 	}
 
 err_exit:
-	if (result && q)
+	if (result)
 		acpi_ec_delete_query(q);
 	if (data)
 		*data = value;