From: Eric Wong <e@80x24.org>
Date: Tue, 5 Sep 2023 07:37:25 +0000 (+0000)
Subject: dskqxs: get rid of needless confess check
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=49898510175f0e9ea62bea83fb333c85b8278362;p=thirdparty%2Fpublic-inbox.git

dskqxs: get rid of needless confess check

Destruction order is unpredictable at process teardown,
so confessing or warning here is unnecessary, just break
out of the sub since it's for to delete an entry, anyways.
---

diff --git a/lib/PublicInbox/DSKQXS.pm b/lib/PublicInbox/DSKQXS.pm
index 7bd7773e7..3fcb4e403 100644
--- a/lib/PublicInbox/DSKQXS.pm
+++ b/lib/PublicInbox/DSKQXS.pm
@@ -106,8 +106,7 @@ sub epoll_ctl {
 		$kq->EV_SET($fd, EVFILT_READ, kq_flag(EPOLLIN, $ev));
 		eval { $kq->EV_SET($fd, EVFILT_WRITE, kq_flag(EPOLLOUT, $ev)) };
 	} elsif ($op == EPOLL_CTL_DEL) {
-		use Carp ();
-		$kq // Carp::confess("nokq $fd");
+		$kq // return; # called in cleanup
 		$kq->EV_SET($fd, EVFILT_READ, EV_DISABLE);
 		eval { $kq->EV_SET($fd, EVFILT_WRITE, EV_DISABLE) };
 	} else { # EPOLL_CTL_ADD