From: Philippe Waroquiers Date: Sun, 23 Aug 2015 16:57:55 +0000 (+0000) Subject: Use memset + assign to VgdbShared, to avoid memcheck warning that X-Git-Tag: svn/VALGRIND_3_11_0~71 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4998bd20e09b270d23f83fd16168c8d30f919657;p=thirdparty%2Fvalgrind.git Use memset + assign to VgdbShared, to avoid memcheck warning that uninit holes bytes are written to the shared file. git-svn-id: svn://svn.valgrind.org/valgrind/trunk@15586 --- diff --git a/coregrind/m_gdbserver/remote-utils.c b/coregrind/m_gdbserver/remote-utils.c index df56b63272..f6f3d0bcf3 100644 --- a/coregrind/m_gdbserver/remote-utils.c +++ b/coregrind/m_gdbserver/remote-utils.c @@ -310,17 +310,20 @@ void remote_open (const HChar *name) { const HChar *user, *host; int len; - VgdbShared vgdbinit = + VgdbShared vgdbinit; + const int pid = VG_(getpid)(); + Addr addr_shared; + SysRes o; + int shared_mem_fd = INVALID_DESCRIPTOR; + + VG_(memset) (&vgdbinit, 0, sizeof (VgdbShared)); + vgdbinit = (VgdbShared) {0, 0, (Addr) VG_(invoke_gdbserver), (Addr) VG_(threads), VG_N_THREADS, sizeof(ThreadState), offsetof(ThreadState, status), offsetof(ThreadState, os_state) + offsetof(ThreadOSstate, lwpid), 0}; - const int pid = VG_(getpid)(); - Addr addr_shared; - SysRes o; - int shared_mem_fd = INVALID_DESCRIPTOR; - + user = VG_(getenv)("LOGNAME"); if (user == NULL) user = VG_(getenv)("USER"); if (user == NULL) user = "???";